Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods 3.2.8 #7347

Merged
merged 77 commits into from
Nov 17, 2024
Merged

Pods 3.2.8 #7347

merged 77 commits into from
Nov 17, 2024

Conversation

PodsBot
Copy link
Collaborator

@PodsBot PodsBot commented Aug 31, 2024

Automated changes by create-pull-request GitHub action

Copy link

what-the-diff bot commented Aug 31, 2024

PR Summary

  • Updated Coding Standards
    The former coding standards used in the project, TribalScents, were replaced with the StellarWP standard. As part of this change, some rules were also excluded.

  • Changed dependencies
    The project no longer depends on "the-events-calendar/coding-standards". Instead, it now utilizes "stellarwp/coding-standards".

  • Improved Functionality in 'general.php'
    The pods_shortcode_run function has been updated to increase its reliability when assigning variables and checking conditions.

  • Version Upgrade
    The plugin, as well as the version in the package.json file and the stable tag version in the readme.txt, were all upgraded from 3.2.7 to 3.2.8-a-1.

  • Added Content Formatting Option in 'Base.php'
    A method, should_autop, was implemented to decide whether the wpautop (a function that automatically adds line breaks and paragraph tags to text) should be applied to block content output.

  • Enhanced Content Rendering in 'Field.php', 'Item_List.php', and 'Related_Item_List.php'
    The render method in these files now calls the previously mentioned should_autop method when determining how to format the content.

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
PEAR.NamingConventions.ValidFunctionName.ScopeNotCamelCaps
Public method name "Base::should_autop" is not in camel caps format

public function should_autop( $content, array $attributes = [] ): bool {


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionDeclaration.BraceOnSameLine
Opening brace should be on a new line

public function should_autop( $content, array $attributes = [] ): bool {


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

$should_autop = (


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

is_string( $content )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

&& false === strpos( $content, '<div' )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

&& false === strpos( $content, '<ul' )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

&& false === strpos( $content, '<ol' )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

&& false === strpos( $content, '<h' )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

&& false === strpos( $content, '<p' )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* Allow filtering whether to apply wpautop to the block content output.


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* This is used for things like Field block render or List block render of the no items found message.


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 110 characters

* This is used for things like Field block render or List block render of the no items found message.


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* @since TBD


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* @param bool $should_autop Whether to apply wpautop to the block content output.


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 98 characters

* @param bool $should_autop Whether to apply wpautop to the block content output.


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* @param string|mixed $content The content to determine whether to autop.


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 87 characters

* @param string|mixed $content The content to determine whether to autop.


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* @param array $attributes The Pods render attributes that will be used.


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 90 characters

* @param array $attributes The Pods render attributes that will be used.


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

return (bool) apply_filters( 'pods_blocks_should_autop', $should_autop, $content, $attributes );


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 104 characters

return (bool) apply_filters( 'pods_blocks_should_autop', $should_autop, $content, $attributes );


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

if ( $this->should_autop( $content, $attributes ) ) {


[phpcs] reported by reviewdog 🐶
PEAR.ControlStructures.MultiLineCondition.SpacingAfterOpenBrace
First condition of a multi-line IF statement must directly follow the opening parenthesis

if ( $this->should_autop( $content, $attributes ) ) {


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
PEAR.ControlStructures.MultiLineCondition.SpacingAfterOpenBrace
First condition of a multi-line IF statement must directly follow the opening parenthesis

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 103 characters

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 88 characters

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
PEAR.ControlStructures.MultiLineCondition.SpacingAfterOpenBrace
First condition of a multi-line IF statement must directly follow the opening parenthesis

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 103 characters

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.TooLong
Line exceeds 85 characters; contains 88 characters

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

$should_autop = (


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

is_string( $content )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

&& false === strpos( $content, '<div' )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

&& false === strpos( $content, '<ul' )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

&& false === strpos( $content, '<ol' )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

&& false === strpos( $content, '<h' )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

&& false === strpos( $content, '<p' )


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* Allow filtering whether to apply wpautop to the block content output.


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* This is used for things like Field block render or List block render of the no items found message.


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.MaxExceeded
Line exceeds maximum limit of 100 characters; contains 110 characters

* This is used for things like Field block render or List block render of the no items found message.


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* @since TBD


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* @param bool $should_autop Whether to apply wpautop to the block content output.


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* @param string|mixed $content The content to determine whether to autop.


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

* @param array $attributes The Pods render attributes that will be used.


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

return (bool) apply_filters( 'pods_blocks_should_autop', $should_autop, $content, $attributes );


[phpcs] reported by reviewdog 🐶
Generic.Formatting.NoSpaceAfterCast.SpaceFound
A cast statement must not be followed by a space

return (bool) apply_filters( 'pods_blocks_should_autop', $should_autop, $content, $attributes );


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.MaxExceeded
Line exceeds maximum limit of 100 characters; contains 104 characters

return (bool) apply_filters( 'pods_blocks_should_autop', $should_autop, $content, $attributes );


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

if ( $this->should_autop( $content, $attributes ) ) {


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.MaxExceeded
Line exceeds maximum limit of 100 characters; contains 103 characters

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
Generic.Files.LineLength.MaxExceeded
Line exceeds maximum limit of 100 characters; contains 103 characters

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );


[phpcs] reported by reviewdog 🐶
Generic.WhiteSpace.DisallowTabIndent.TabsUsed
Spaces must be used to indent lines; tabs are not allowed

@sc0ttkclark sc0ttkclark marked this pull request as ready for review August 31, 2024 02:24
@sc0ttkclark sc0ttkclark marked this pull request as draft August 31, 2024 02:24
@pods-framework pods-framework deleted a comment from PodsBot Aug 31, 2024
Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket
Space after opening parenthesis of function call prohibited

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket
Expected 0 spaces before closing parenthesis; 1 found

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket
Space after opening parenthesis of function call prohibited

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket
Expected 0 spaces before closing parenthesis; 1 found

if ( ! empty( $attributes['not_found'] ) && $this->should_autop( $attributes['not_found'] ) ) {


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket
Space after opening parenthesis of function call prohibited

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket
Expected 0 spaces before closing parenthesis; 1 found

$attributes['not_found'] = wpautop( $attributes['not_found'], $attributes );

<?php echo( $submit_from_linked ? 'class="hidden"' : '' ); ?>>
<h2 class="pods-wizard-one-click-actions-heading"><?php esc_html_e( 'One-Click Extend', 'pods' ); ?></h2>
<ul class="pods-wizard-one-click-actions">
<?php foreach ( $quick_actions as $quick_action_key => $quick_action ) : ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$quick_action_key".

<?php echo( $submit_from_linked ? 'class="hidden"' : '' ); ?>>
<h2 class="pods-wizard-one-click-actions-heading"><?php esc_html_e( 'One-Click Extend', 'pods' ); ?></h2>
<ul class="pods-wizard-one-click-actions">
<?php foreach ( $quick_actions as $quick_action_key => $quick_action ) : ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$quick_action".

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'pods_v'.

echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'pods_v'.

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [


[phpcs] reported by reviewdog 🐶
Squiz.PHP.EmbeddedPhp.ContentAfterOpen
Opening PHP tag must be on a line by itself

<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$capability'.

<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'pods_v'.

<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$obj'

echo $obj->message( wp_kses_post( $message ) );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$obj'.

echo $obj->message( wp_kses_post( $message ) );


[phpcs] reported by reviewdog 🐶
WordPressVIPMinimum.Security.ProperEscapingFunction.htmlAttrNotByEscHTML
Wrong escaping function. HTML attributes should be escaped by esc_attr(), not by esc_html_e().

<input type="submit" name="publish" id="publish" class="button-primary" value="<?php esc_html_e( 'Save', 'pods' ); ?>" accesskey="p" />


[phpcs] reported by reviewdog 🐶
Squiz.Strings.EchoedStrings.HasBracket
Echoed strings should not be bracketed

<div class="pods-wizard-option<?php echo ( ! empty( $quick_actions ) ? ' pods-wizard-option-with-secondary' : '' ); ?>">


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '!'

<div class="pods-wizard-option<?php echo ( ! empty( $quick_actions ) ? ' pods-wizard-option-with-secondary' : '' ); ?>">


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

<div class="pods-wizard-option<?php echo ( ! empty( $quick_actions ) ? ' pods-wizard-option-with-secondary' : '' ); ?>">


[phpcs] reported by reviewdog 🐶
Squiz.Strings.EchoedStrings.HasBracket
Echoed strings should not be bracketed

<?php echo ( $submit_from_linked ? 'class="hidden"' : '' ); ?>>


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$submit_from_linked'

<?php echo ( $submit_from_linked ? 'class="hidden"' : '' ); ?>>


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

<?php echo ( $submit_from_linked ? 'class="hidden"' : '' ); ?>>

<ul>
<?php
foreach ( $post_types as $post_type ) {
$post_type_name = pods_var_raw( 'name', $post_type );
$post_type_label = pods_var_raw( 'label', $post_type, ucwords( str_replace( '_', ' ', $post_type_name ) ) );
$post_type_name = pods_v( 'name', $post_type );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$post_type_name".

$post_type_name = pods_var_raw( 'name', $post_type );
$post_type_label = pods_var_raw( 'label', $post_type, ucwords( str_replace( '_', ' ', $post_type_name ) ) );
$post_type_name = pods_v( 'name', $post_type );
$post_type_label = pods_v( 'label', $post_type, ucwords( str_replace( '_', ' ', $post_type_name ) ) );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$post_type_label".

?>
<li>
<div class="pods-field pods-boolean">
<?php
echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_var_raw( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [
echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_v( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

?>
<li>
<div class="pods-field pods-boolean">
<?php
echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_var_raw( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [
echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_v( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

?>
<li>
<div class="pods-field pods-boolean">
<?php
echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_var_raw( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [
echo PodsForm::field( 'post_type[' . $post_type_name . ']', pods_v( 'post_type[' . $post_type_name . ']', 'post', true ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$post_type_name'.

?>
<li>
<?php
echo PodsForm::field( 'taxonomy[' . $taxonomy_name . ']', pods_var_raw( 'taxonomy[' . $taxonomy_name . ']', 'post', true ), 'boolean', [
echo PodsForm::field( 'taxonomy[' . $taxonomy_name . ']', pods_v( 'taxonomy[' . $taxonomy_name . ']', 'post', true ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

@@ -321,9 +325,9 @@

$capabilities = $this->get_capabilities();

$params->capabilities = (array) pods_var_raw( 'capabilities', $params, array() );
$params->capabilities = (array) pods_v( 'capabilities', $params, array() );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays


$params->custom_capabilities = (array) pods_var_raw( 'custom_capabilities', $params, array() );
$params->custom_capabilities = (array) pods_v( 'custom_capabilities', $params, array() );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
'class' => 'pods-validate pods-validate-required',
'disable_dfv' => true,
echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
'class' => 'pods-validate pods-validate-required',
'disable_dfv' => true,
echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
'class' => 'pods-validate pods-validate-required',
'disable_dfv' => true,
echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'pods_v'.

echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
'class' => 'pods-validate pods-validate-required',
'disable_dfv' => true,
echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
'class' => 'pods-validate pods-validate-required',
'disable_dfv' => true,
echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( 'role_label', pods_var_raw( 'role_label', 'post' ), 'text', [
'class' => 'pods-validate pods-validate-required',
'disable_dfv' => true,
echo PodsForm::field( 'role_label', pods_v( 'role_label', 'post' ), 'text', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

'attributes' => [ 'data-sluggable' => 'role_label' ],
'class' => 'pods-validate pods-validate-required pods-slugged-lower',
'disable_dfv' => true,
echo PodsForm::field( 'role_name', pods_v( 'role_name', 'post' ), 'slug', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

@@ -90,7 +88,7 @@
$zebra = ( ! $zebra );
?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

@@ -90,7 +88,7 @@
$zebra = ( ! $zebra );
?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
<?php echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

@@ -21,11 +21,11 @@

$message = sprintf( __( '<strong>Success!</strong> %1$s %2$s successfully.', 'pods' ), $obj->item, $action );

echo $obj->message( $message );
echo $obj->message( wp_kses_post( $message ) );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$obj'

@@ -21,11 +21,11 @@

$message = sprintf( __( '<strong>Success!</strong> %1$s %2$s successfully.', 'pods' ), $obj->item, $action );

echo $obj->message( $message );
echo $obj->message( wp_kses_post( $message ) );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$obj'.


<div class="inside">
<div class="submitbox" id="submitpost">
<div id="minor-publishing">
<div id="major-publishing-actions">
<div id="publishing-action">
<img class="waiting" src="<?php echo esc_url( admin_url( 'images/wpspin_light.gif' ) ); ?>" alt="" />
<input type="submit" name="publish" id="publish" class="button-primary" value="<?php _e( 'Save', 'pods' ); ?>" accesskey="p" />
<input type="submit" name="publish" id="publish" class="button-primary" value="<?php esc_html_e( 'Save', 'pods' ); ?>" accesskey="p" />
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPressVIPMinimum.Security.ProperEscapingFunction.htmlAttrNotByEscHTML
Wrong escaping function. HTML attributes should be escaped by esc_attr(), not by esc_html_e().

ui/js/jquery.pods.js Fixed Show fixed Hide fixed
ui/js/jquery.pods.js Fixed Show fixed Hide fixed
ui/js/jquery.pods.js Fixed Show fixed Hide fixed
ui/js/jquery.pods.js Fixed Show fixed Hide fixed
ui/js/jquery.pods.js Fixed Show fixed Hide fixed
ui/js/jquery.pods.js Dismissed Show dismissed Hide dismissed
ui/js/jquery.pods.js Dismissed Show dismissed Hide dismissed
@@ -99,7 +99,7 @@
?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
<?php
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

@@ -99,7 +99,7 @@
?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
<?php
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

@@ -99,7 +99,7 @@
?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
<?php
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$capability'.

@@ -99,7 +99,7 @@
?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
<?php
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'pods_v'.

@@ -99,7 +99,7 @@
?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
<?php
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

@@ -99,7 +99,7 @@
?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
<?php
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

@@ -99,7 +99,7 @@
?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>" data-capability="<?php echo esc_attr( $capability ); ?>">
<?php
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_var_raw( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
echo PodsForm::field( 'capabilities[' . $capability . ']', pods_v( 'capabilities[' . $capability . ']', 'post', $checked ), 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

</a>
</div>

<div class="pods-wizard-option">
<div class="pods-wizard-option<?php echo ! empty( $quick_actions ) ? ' pods-wizard-option-with-secondary' : ''; ?>">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed


<?php if ( ! empty( $quick_actions ) ) : ?>
<div id="pods-wizard-quick-actions"
<?php echo $submit_from_linked ? 'class="hidden"' : ''; ?>>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

@@ -569,6 +567,14 @@
</div>
</div>
</div>

<div id="pods-wizard-quick-actions-saving-in-progress"
<?php echo ! $submit_from_linked ? 'class="hidden"' : ''; ?>>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

@sc0ttkclark sc0ttkclark marked this pull request as ready for review September 14, 2024 15:11
@@ -5,8 +5,12 @@
* @package Pods_templates
*/

$has_php = false;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$has_php".

if ( isset( $content ) ) {
$has_php = false !== strpos( $content, '<?' );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$has_php".

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

<?php echo PodsForm::field( '_wpnonce', wp_create_nonce( 'pods-component-' . $component . '-' . $method ), 'hidden' ); ?>


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'wp_create_nonce'.

<?php echo PodsForm::field( '_wpnonce', wp_create_nonce( 'pods-component-' . $component . '-' . $method ), 'hidden' ); ?>


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'

<?php echo PodsForm::field( '_wpnonce', wp_create_nonce( 'pods-component-' . $component . '-' . $method ), 'hidden' ); ?>


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data".

$data = $pod_templates;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data_name".

$data_name = 'templates';


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$item".

foreach ( $data as $item ) {


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$checked".


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$class".

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".

$zebra = ( ! $zebra );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data".

$data = $pod_pages;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data_name".

$data_name = 'pages';


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$item".

foreach ( $data as $item ) {


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$checked".

$checked = true;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$class".

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".

$zebra = ( ! $zebra );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
Universal.NamingConventions.NoReservedKeywordParameterNames.objectFound
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object

public static function object_to_page( Page $object ): array {


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.InlineComment.InvalidEndChar
Inline comments must end in full-stops, exclamation marks, or question marks

// phpcode is deprecated


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'admin_only' => (boolean) get_post_meta( $id, 'admin_only', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_role' => (boolean) get_post_meta( $id, 'restrict_role', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_capability' => (boolean) get_post_meta( $id, 'restrict_capability', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_redirect' => (boolean) get_post_meta( $id, 'restrict_redirect', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_redirect_login' => (boolean) get_post_meta( $id, 'restrict_redirect_login', true ),


[phpcs] reported by reviewdog 🐶
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

$default_templates = array(


<form action="" method="post" class="pods-submittable">
<div class="pods-submittable-fields">
<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FileComment.Missing
Missing file doc comment


<form action="" method="post" class="pods-submittable">
<div class="pods-submittable-fields">
<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.


<form action="" method="post" class="pods-submittable">
<div class="pods-submittable-fields">
<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'

<form action="" method="post" class="pods-submittable">
<div class="pods-submittable-fields">
<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

<form action="" method="post" class="pods-submittable">
<div class="pods-submittable-fields">
<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$component'.

<form action="" method="post" class="pods-submittable">
<div class="pods-submittable-fields">
<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'

<div class="pods-submittable-fields">
<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
<?php echo PodsForm::field( 'method', $method, 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

<div class="pods-submittable-fields">
<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
<?php echo PodsForm::field( 'method', $method, 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$method'.

<div class="pods-submittable-fields">
<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
<?php echo PodsForm::field( 'method', $method, 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data".

$data = $pod_pages;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data_name".

$data_name = 'pages';


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$item".

foreach ( $data as $item ) {


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$checked".

$checked = true;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$class".

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".

$zebra = ( ! $zebra );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
Universal.NamingConventions.NoReservedKeywordParameterNames.objectFound
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object

public static function object_to_page( Page $object ): array {


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.InlineComment.InvalidEndChar
Inline comments must end in full-stops, exclamation marks, or question marks

// phpcode is deprecated


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'admin_only' => (boolean) get_post_meta( $id, 'admin_only', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_role' => (boolean) get_post_meta( $id, 'restrict_role', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_capability' => (boolean) get_post_meta( $id, 'restrict_capability', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_redirect' => (boolean) get_post_meta( $id, 'restrict_redirect', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_redirect_login' => (boolean) get_post_meta( $id, 'restrict_redirect_login', true ),


[phpcs] reported by reviewdog 🐶
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

$default_templates = array(

<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
<?php echo PodsForm::field( 'method', $method, 'hidden' ); ?>
<?php echo PodsForm::field( '_wpnonce', wp_create_nonce( 'pods-component-' . $component . '-' . $method ), 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
<?php echo PodsForm::field( 'method', $method, 'hidden' ); ?>
<?php echo PodsForm::field( '_wpnonce', wp_create_nonce( 'pods-component-' . $component . '-' . $method ), 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'wp_create_nonce'.

<?php echo PodsForm::field( 'action', 'pods_admin_components', 'hidden' ); ?>
<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
<?php echo PodsForm::field( 'method', $method, 'hidden' ); ?>
<?php echo PodsForm::field( '_wpnonce', wp_create_nonce( 'pods-component-' . $component . '-' . $method ), 'hidden' ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'

<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
<?php echo PodsForm::field( 'method', $method, 'hidden' ); ?>
<?php echo PodsForm::field( '_wpnonce', wp_create_nonce( 'pods-component-' . $component . '-' . $method ), 'hidden' ); ?>
<?php echo PodsForm::field( 'cleanup', 0, 'hidden', array( 'attributes' => array( 'id' => 'pods_cleanup' ) ) ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
<?php echo PodsForm::field( 'method', $method, 'hidden' ); ?>
<?php echo PodsForm::field( '_wpnonce', wp_create_nonce( 'pods-component-' . $component . '-' . $method ), 'hidden' ); ?>
<?php echo PodsForm::field( 'cleanup', 0, 'hidden', array( 'attributes' => array( 'id' => 'pods_cleanup' ) ) ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
<?php echo PodsForm::field( 'method', $method, 'hidden' ); ?>
<?php echo PodsForm::field( '_wpnonce', wp_create_nonce( 'pods-component-' . $component . '-' . $method ), 'hidden' ); ?>
<?php echo PodsForm::field( 'cleanup', 0, 'hidden', array( 'attributes' => array( 'id' => 'pods_cleanup' ) ) ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

<?php echo PodsForm::field( 'component', $component, 'hidden' ); ?>
<?php echo PodsForm::field( 'method', $method, 'hidden' ); ?>
<?php echo PodsForm::field( '_wpnonce', wp_create_nonce( 'pods-component-' . $component . '-' . $method ), 'hidden' ); ?>
<?php echo PodsForm::field( 'cleanup', 0, 'hidden', array( 'attributes' => array( 'id' => 'pods_cleanup' ) ) ); ?>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
Universal.NamingConventions.NoReservedKeywordParameterNames.objectFound
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object

public static function object_to_page( Page $object ): array {


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.InlineComment.InvalidEndChar
Inline comments must end in full-stops, exclamation marks, or question marks

// phpcode is deprecated


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'admin_only' => (boolean) get_post_meta( $id, 'admin_only', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_role' => (boolean) get_post_meta( $id, 'restrict_role', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_capability' => (boolean) get_post_meta( $id, 'restrict_capability', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_redirect' => (boolean) get_post_meta( $id, 'restrict_redirect', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_redirect_login' => (boolean) get_post_meta( $id, 'restrict_redirect_login', true ),


[phpcs] reported by reviewdog 🐶
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

$default_templates = array(

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_redirect' => (boolean) get_post_meta( $id, 'restrict_redirect', true ),


[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_redirect_login' => (boolean) get_post_meta( $id, 'restrict_redirect_login', true ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'self'

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'self'.

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$obj'

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$obj'.

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'true'

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'self'

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'self'.

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$obj'

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$obj'.

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'true'

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$template_output'

echo $template_output;


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$template_output'.

echo $template_output;


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$template_output'

echo $template_output;


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$template_output'.

echo $template_output;


[phpcs] reported by reviewdog 🐶
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

$default_templates = array(


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

$data = get_file_data( $file_path, [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

$data = get_file_data( $file_path, [


[phpcs] reported by reviewdog 🐶
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'PodTemplate'" and double arrow, but found 2.

'PodTemplate' => 'Pod Template',


[phpcs] reported by reviewdog 🐶
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 3 space(s) between "'MagicTags'" and double arrow, but found 1.

'MagicTags' => 'Magic Tags',


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.ParamCommentFullStop
Parameter comment must end with a full stop

* @param string $code The template string to parse


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.ParamCommentFullStop
Parameter comment must end with a full stop

* @param object $obj The Pods object


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'admin_url'.

admin_url( 'admin.php?page=pods-components' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'

admin_url( 'admin.php?page=pods-components' ),

'name' => 'precode_notice',
'type' => 'html',
'html_content' => sprintf(
'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.Indent
Multi-line function call not indented correctly; expected 20 spaces but found 12

'name' => 'precode_notice',
'type' => 'html',
'html_content' => sprintf(
'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Arrays.ArrayIndentation.MultiLineArrayItemNotAligned
Multi-line array item not aligned correctly; expected 16 spaces, but found 12

@@ -653,6 +696,93 @@

add_action( 'admin_enqueue_scripts', array( $this, 'admin_assets' ), 21 );
add_filter( 'enter_title_here', array( $this, 'set_title_text' ), 10, 2 );

$page_code = get_the_content();
$pre_code = get_post_meta( get_the_ID(), 'precode', true );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

$page_code = get_the_content();
$pre_code = get_post_meta( get_the_ID(), 'precode', true );

$has_php = false !== strpos( $page_code, '<?' );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

*
* @return array The Pod Page data array.
*/
public static function object_to_page( Page $object ): array {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Universal.NamingConventions.NoReservedKeywordParameterNames.objectFound
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$obj'

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$obj'.

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'true'

echo self::do_template( $code, $obj, true );


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$template_output'

echo $template_output;


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$template_output'.

echo $template_output;


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$template_output'

echo $template_output;


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$template_output'.

echo $template_output;


[phpcs] reported by reviewdog 🐶
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

$default_templates = array(


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

$data = get_file_data( $file_path, [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

$data = get_file_data( $file_path, [


[phpcs] reported by reviewdog 🐶
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'PodTemplate'" and double arrow, but found 2.

'PodTemplate' => 'Pod Template',


[phpcs] reported by reviewdog 🐶
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 3 space(s) between "'MagicTags'" and double arrow, but found 1.

'MagicTags' => 'Magic Tags',


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.ParamCommentFullStop
Parameter comment must end with a full stop

* @param string $code The template string to parse


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.ParamCommentFullStop
Parameter comment must end with a full stop

* @param object $obj The Pods object


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'admin_url'.

admin_url( 'admin.php?page=pods-components' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'

admin_url( 'admin.php?page=pods-components' ),

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

$default_templates = array(


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

$data = get_file_data( $file_path, [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

$data = get_file_data( $file_path, [


[phpcs] reported by reviewdog 🐶
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'PodTemplate'" and double arrow, but found 2.

'PodTemplate' => 'Pod Template',


[phpcs] reported by reviewdog 🐶
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 3 space(s) between "'MagicTags'" and double arrow, but found 1.

'MagicTags' => 'Magic Tags',


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.ParamCommentFullStop
Parameter comment must end with a full stop

* @param string $code The template string to parse


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.ParamCommentFullStop
Parameter comment must end with a full stop

* @param object $obj The Pods object


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'admin_url'.

admin_url( 'admin.php?page=pods-components' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'

admin_url( 'admin.php?page=pods-components' ),

'uri' => $object->get_label(),
'code' => $object->get_description(),
'phpcode' => $object->get_description(),
// phpcode is deprecated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Commenting.InlineComment.InvalidEndChar
Inline comments must end in full-stops, exclamation marks, or question marks

'page_template' => get_post_meta( $id, 'page_template', true ),
'title' => get_post_meta( $id, 'page_title', true ),
'options' => [
'admin_only' => (boolean) get_post_meta( $id, 'admin_only', true ),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'title' => get_post_meta( $id, 'page_title', true ),
'options' => [
'admin_only' => (boolean) get_post_meta( $id, 'admin_only', true ),
'restrict_role' => (boolean) get_post_meta( $id, 'restrict_role', true ),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'options' => [
'admin_only' => (boolean) get_post_meta( $id, 'admin_only', true ),
'restrict_role' => (boolean) get_post_meta( $id, 'restrict_role', true ),
'restrict_capability' => (boolean) get_post_meta( $id, 'restrict_capability', true ),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

'restrict_capability' => (boolean) get_post_meta( $id, 'restrict_capability', true ),
'roles_allowed' => get_post_meta( $id, 'roles_allowed', true ),
'capability_allowed' => get_post_meta( $id, 'capability_allowed', true ),
'restrict_redirect' => (boolean) get_post_meta( $id, 'restrict_redirect', true ),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

@@ -641,17 +667,13 @@
&& ! pods_access_bypass_private_post( $info )
)
) {
echo self::do_template( $code, $obj );
echo self::do_template( $code, $obj, true );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not 'true'

$template_output = self::do_template( $template_output, $obj );
}

echo $template_output;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$template_output'

$template_output = self::do_template( $template_output, $obj );
}

echo $template_output;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$template_output'.

$template_output = self::do_template( $template_output, $obj );
}

echo $template_output;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not '$template_output'

$template_output = self::do_template( $template_output, $obj );
}

echo $template_output;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$template_output'.

public static function get_templates_for_pod_template( $template, $obj = null ): array {
$template_name = trim( preg_replace( '/[^a-zA-Z0-9_\-\/]/', '', $template->get_name() ), ' /-' );

$default_templates = array(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Generic.Arrays.DisallowLongArraySyntax.Found
Short array syntax must be used to define arrays

continue;
}

$data = get_file_data( $file_path, [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

continue;
}

$data = get_file_data( $file_path, [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

}

$data = get_file_data( $file_path, [
'PodTemplate' => 'Pod Template',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'PodTemplate'" and double arrow, but found 2.


$data = get_file_data( $file_path, [
'PodTemplate' => 'Pod Template',
'MagicTags' => 'Magic Tags',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 3 space(s) between "'MagicTags'" and double arrow, but found 1.

$data = get_file_data( $file_path, [
'PodTemplate' => 'Pod Template',
'MagicTags' => 'Magic Tags',
] );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself

/**
* Parse a template string
*
* @param string $code The template string to parse
* @param object $obj The Pods object
* @param string $code The template string to parse
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.ParamCommentFullStop
Parameter comment must end with a full stop

* @param string $code The template string to parse
* @param object $obj The Pods object
* @param string $code The template string to parse
* @param object $obj The Pods object
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.ParamCommentFullStop
Parameter comment must end with a full stop

esc_html__( 'PHP detected, this feature is deprecated', 'pods' ),
'https://docs.pods.io/displaying-pods/pod-template-hierarchy-for-themes/',
esc_html__( 'Read more about file-based templates', 'pods' ),
admin_url( 'admin.php?page=pods-components' ),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'admin_url'.

esc_html__( 'PHP detected, this feature is deprecated', 'pods' ),
'https://docs.pods.io/displaying-pods/pod-template-hierarchy-for-themes/',
esc_html__( 'Read more about file-based templates', 'pods' ),
admin_url( 'admin.php?page=pods-components' ),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

if ( true === (boolean) $checked && isset( $pod_pages_available_to_migrate[ (int) $object_id ] ) ) {


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function setup_file_path()

private function setup_file_path( $file_path ) {


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function migrate_template()

private function migrate_template( $object_id, bool $cleanup ) {


[phpcs] reported by reviewdog 🐶
WordPress.WP.AlternativeFunctions.json_encode_json_encode
json_encode() is discouraged. Use wp_json_encode() instead.

pods_error( sprintf( esc_html__( 'Unable to detect the file path: %s', 'pods' ), json_encode( $files, JSON_PRETTY_PRINT ) ) );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.Heredoc.NotAllowed
Use of heredoc and nowdoc syntax ("<<<") is not allowed; use standard strings or inline HTML instead

$extra_headers = <<<PHPTEMPLATE


[phpcs] reported by reviewdog 🐶
Squiz.PHP.Heredoc.NotAllowed
Use of heredoc and nowdoc syntax ("<<<") is not allowed; use standard strings or inline HTML instead

$contents = <<<PHPTEMPLATE


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

$api->save_template( [


[phpcs] reported by reviewdog 🐶
WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned
Array double arrow not aligned correctly; expected 1 space(s) between "'name'" and double arrow, but found 3.

'name' => $object->get_label(),


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.Missing
Missing doc comment for function migrate_page()

private function migrate_page( $object_id, bool $cleanup ) {


[phpcs] reported by reviewdog 🐶
WordPress.WP.AlternativeFunctions.json_encode_json_encode
json_encode() is discouraged. Use wp_json_encode() instead.

pods_error( sprintf( esc_html__( 'Unable to detect the file path: %s', 'pods' ), json_encode( $files, JSON_PRETTY_PRINT ) ) );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.Heredoc.NotAllowed
Use of heredoc and nowdoc syntax ("<<<") is not allowed; use standard strings or inline HTML instead

$precode_template = "\n" . <<<PHPTEMPLATE


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

$template_code = "?>\n" . $template_code . ( ! $has_page_template ? '' : "\n<?php" );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.Heredoc.NotAllowed
Use of heredoc and nowdoc syntax ("<<<") is not allowed; use standard strings or inline HTML instead

$template_code = $start_tag . <<<PHPTEMPLATE


[phpcs] reported by reviewdog 🐶
Squiz.PHP.Heredoc.NotAllowed
Use of heredoc and nowdoc syntax ("<<<") is not allowed; use standard strings or inline HTML instead

$extra_notes .= "\n" . <<<PHPTEMPLATE


[phpcs] reported by reviewdog 🐶
Generic.Formatting.MultipleStatementAlignment.NotSameWarning
Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

$file_path = $file_path_for_content;


[phpcs] reported by reviewdog 🐶
Squiz.PHP.Heredoc.NotAllowed
Use of heredoc and nowdoc syntax ("<<<") is not allowed; use standard strings or inline HTML instead

$extra_notes .= "\n" . <<<PHPTEMPLATE


[phpcs] reported by reviewdog 🐶
Squiz.PHP.Heredoc.NotAllowed
Use of heredoc and nowdoc syntax ("<<<") is not allowed; use standard strings or inline HTML instead

$extra_headers = "\n" . <<<PHPTEMPLATE


[phpcs] reported by reviewdog 🐶
Squiz.PHP.Heredoc.NotAllowed
Use of heredoc and nowdoc syntax ("<<<") is not allowed; use standard strings or inline HTML instead

$contents = <<<PHPTEMPLATE


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

$api->save_page( [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
PSR2.Classes.ClassDeclaration.CloseBraceAfterBody
The closing brace for the class must go on the next line after the body


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data".

$data = $pod_templates;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data_name".

$data_name = 'templates';


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$item".

foreach ( $data as $item ) {


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$checked".


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$class".

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".

$zebra = ( ! $zebra );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data".

$data = $pod_pages;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data_name".

$data_name = 'pages';


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$item".

foreach ( $data as $item ) {


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$checked".

$checked = true;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$class".

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".

$zebra = ( ! $zebra );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself

if ( class_exists( 'Pods_Templates' ) ) {
$pod_templates = array_filter(
$api->load_templates(),
static function( $object ) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Functions.MultiLineFunctionDeclaration.SpaceAfterFunction
Expected 1 space after FUNCTION keyword; 0 found

if ( class_exists( 'Pods_Templates' ) ) {
$pod_templates = array_filter(
$api->load_templates(),
static function( $object ) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Universal.NamingConventions.NoReservedKeywordParameterNames.objectFound
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object

if ( class_exists( 'Pods_Pages' ) ) {
$pod_pages = array_filter(
$api->load_pages(),
static function( $object ) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Functions.MultiLineFunctionDeclaration.SpaceAfterFunction
Expected 1 space after FUNCTION keyword; 0 found

if ( class_exists( 'Pods_Pages' ) ) {
$pod_pages = array_filter(
$api->load_pages(),
static function( $object ) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Universal.NamingConventions.NoReservedKeywordParameterNames.objectFound
It is recommended not to use reserved keyword "object" as function parameter name. Found: $object

}

// Rekey the objects by ID.
$pod_templates = array_combine( array_map( static function( $object ) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line


$pod_pages = array_combine( array_map( static function( $object ) {
return $object->get_id();
}, $pod_pages ), $pod_pages );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself

return compact( 'pod_templates', 'pod_pages' );
}

/**
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.MissingParamTag
Doc comment for parameter "$options" missing

return compact( 'pod_templates', 'pod_pages' );
}

/**
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.MissingParamTag
Doc comment for parameter "$component" missing

/**
* Show the Admin
*
* @param $options
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.MissingParamType
Missing parameter type

* Show the Admin
*
* @param $options
* @param $component
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.MissingParamType
Missing parameter type

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
Squiz.PHP.Heredoc.NotAllowed
Use of heredoc and nowdoc syntax ("<<<") is not allowed; use standard strings or inline HTML instead

$extra_notes .= "\n" . <<<PHPTEMPLATE


[phpcs] reported by reviewdog 🐶
Squiz.PHP.Heredoc.NotAllowed
Use of heredoc and nowdoc syntax ("<<<") is not allowed; use standard strings or inline HTML instead

$extra_headers = "\n" . <<<PHPTEMPLATE


[phpcs] reported by reviewdog 🐶
Squiz.PHP.Heredoc.NotAllowed
Use of heredoc and nowdoc syntax ("<<<") is not allowed; use standard strings or inline HTML instead

$contents = <<<PHPTEMPLATE


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

$api->save_page( [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
PSR2.Classes.ClassDeclaration.CloseBraceAfterBody
The closing brace for the class must go on the next line after the body


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data".

$data = $pod_templates;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data_name".

$data_name = 'templates';


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$item".

foreach ( $data as $item ) {


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$checked".


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$class".

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".

$zebra = ( ! $zebra );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data".

$data = $pod_pages;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data_name".

$data_name = 'pages';


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$item".

foreach ( $data as $item ) {


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$checked".

$checked = true;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$class".

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".

$zebra = ( ! $zebra );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
SlevomatCodingStandard.Variables.UselessVariable.UselessVariable
Useless variable $plugin.

$plugin = get_plugin_data( $this->plugin_file, true, false );

$sister_field = $this->load_field( [ 'id' => $sister_id ] );

if ( $sister_field ) {
pods_query( '
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

`related_pod_id` = %d,
`related_field_id` = %d
WHERE `field_id` = %d
', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

`related_field_id` = %d
WHERE `field_id` = %d
', [
$pod['id'],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Arrays.ArrayIndentation.ItemNotAligned
Array item not aligned correctly; expected 4 spaces but found 24

WHERE `field_id` = %d
', [
$pod['id'],
$params->id,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Arrays.ArrayIndentation.ItemNotAligned
Array item not aligned correctly; expected 4 spaces but found 24

', [
$pod['id'],
$params->id,
$sister_id,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Arrays.ArrayIndentation.ItemNotAligned
Array item not aligned correctly; expected 4 spaces but found 24

`related_field_id` = %d
WHERE `field_id` = %d
', [
$sister_field->get_parent_id(),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Arrays.ArrayIndentation.ItemNotAligned
Array item not aligned correctly; expected 4 spaces but found 24

WHERE `field_id` = %d
', [
$sister_field->get_parent_id(),
$sister_id,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Arrays.ArrayIndentation.ItemNotAligned
Array item not aligned correctly; expected 4 spaces but found 24

', [
$sister_field->get_parent_id(),
$sister_id,
$params->id,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Arrays.ArrayIndentation.ItemNotAligned
Array item not aligned correctly; expected 4 spaces but found 24

$sister_field->get_parent_id(),
$sister_id,
$params->id,
] );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Arrays.ArrayIndentation.CloseBraceNotAligned
Array closer not aligned correctly; expected 0 space(s) but found 20

$sister_field->get_parent_id(),
$sister_id,
$params->id,
] );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$checked".

$checked = true;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$class".

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".

$zebra = ( ! $zebra );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data".

$data = $pod_pages;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data_name".

$data_name = 'pages';


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$item".

foreach ( $data as $item ) {


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$checked".

$checked = true;


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$class".

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

$class = ( $zebra ? 'even' : 'odd' );


[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".

$zebra = ( ! $zebra );


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
SlevomatCodingStandard.Variables.UselessVariable.UselessVariable
Useless variable $plugin.

$plugin = get_plugin_data( $this->plugin_file, true, false );


$has_objects_to_migrate = ! empty( $pod_templates ) || ! empty( $pod_pages );

// ajax_migrate
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Commenting.InlineComment.InvalidEndChar
Inline comments must end in full-stops, exclamation marks, or question marks

pods_view( __DIR__ . '/ui/wizard.php', compact( array_keys( get_defined_vars() ) ) );
}

/**
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.MissingParamTag
Doc comment for parameter "$params" missing

/**
* Handle the Migration AJAX
*
* @param $params
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.Commenting.FunctionComment.MissingParamType
Missing parameter type

$has_objects_to_migrate = ! empty( $pod_templates_selected ) || ! empty( $pod_pages_selected );

foreach ( $pod_templates_selected as $object_id => $checked ) {
if ( true === (boolean) $checked && isset( $pod_templates_available_to_migrate[ (int) $object_id ] ) ) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

}

foreach ( $pod_pages_selected as $object_id => $checked ) {
if ( true === (boolean) $checked && isset( $pod_pages_available_to_migrate[ (int) $object_id ] ) ) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PSR12.Keywords.ShortFormTypeKeywords.LongFound
Short form type keywords must be used. Found: (boolean)

return str_replace( ABSPATH, '', $file_path );
}

}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PSR2.Classes.ClassDeclaration.CloseBraceAfterBody
The closing brace for the class must go on the next line after the body


<?php if ( ! empty( $pod_templates ) ) : ?>
<?php
$data = $pod_templates;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data".

<?php if ( ! empty( $pod_templates ) ) : ?>
<?php
$data = $pod_templates;
$data_name = 'templates';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$data_name".


<ul>
<?php
$zebra = false;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".

<?php
$zebra = false;

foreach ( $data as $item ) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$item".

Copy link
Collaborator Author

@PodsBot PodsBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

phpcs

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),


[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'


[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself


[phpcs] reported by reviewdog 🐶
SlevomatCodingStandard.Variables.UselessVariable.UselessVariable
Useless variable $plugin.

$plugin = get_plugin_data( $this->plugin_file, true, false );

$zebra = false;

foreach ( $data as $item ) {
$checked = true;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$checked".

foreach ( $data as $item ) {
$checked = true;

$class = ( $zebra ? 'even' : 'odd' );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$class".

foreach ( $data as $item ) {
$checked = true;

$class = ( $zebra ? 'even' : 'odd' );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed


$class = ( $zebra ? 'even' : 'odd' );

$zebra = ( ! $zebra );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedVariableFound
Global variables defined by a theme/plugin should start with the theme/plugin prefix. Found: "$zebra".

?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>">
<?php
echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found 'PodsForm'.

?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>">
<?php
echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.ContentAfterOpenBracket
Opening parenthesis of a multi-line function call must be the last content on the line

?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>">
<?php
echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['id']'.

?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>">
<?php
echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$checked'.

?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>">
<?php
echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>">
<?php
echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

?>
<li class="pods-zebra-<?php echo esc_attr( $class ); ?>">
<?php
echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.MultipleArguments
Only one argument is allowed per line in a multi-line function call

<li class="pods-zebra-<?php echo esc_attr( $class ); ?>">
<?php
echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['name']'.

<li class="pods-zebra-<?php echo esc_attr( $class ); ?>">
<?php
echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
Squiz.PHP.DisallowInlineIf.Found
Inline IF statements are not allowed

<li class="pods-zebra-<?php echo esc_attr( $class ); ?>">
<?php
echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
WordPress.Security.EscapeOutput.OutputNotEscaped
All output should be run through an escaping function (see the Security sections in the WordPress Developer Handbooks), found '$item['label']'.

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),
'disable_dfv' => true,
] );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
StellarWP.XSS.EscapeOutput.OutputNotEscaped
Expected next thing to be an escaping function (see Codex for 'Data Validation'), not ')'

echo PodsForm::field( $data_name . '[' . $item['id'] . ']', $checked, 'boolean', [
'boolean_yes_label' => $item['name'] . ( ! empty( $item['label'] ) ? ' (' . $item['label'] . ')' : '' ),
'disable_dfv' => true,
] );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
PEAR.Functions.FunctionCallSignature.CloseBracketLine
Closing parenthesis of a multi-line function call must be on a line by itself

@@ -375,7 +375,7 @@ public function plugin_data() {
include ABSPATH . '/wp-admin/includes/plugin.php';
}
// Retrieve current plugin information
$plugin = get_plugin_data( $this->plugin_file );
$plugin = get_plugin_data( $this->plugin_file, true, false );
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[phpcs] reported by reviewdog 🐶
SlevomatCodingStandard.Variables.UselessVariable.UselessVariable
Useless variable $plugin.

@PodsBot
Copy link
Collaborator Author

PodsBot commented Nov 17, 2024

Total number of active review comments per pull request has been reached and some comments might not appear as a result. Please resolve some issues to see more (commit-ID: a780c71).

@sc0ttkclark sc0ttkclark merged commit a780c71 into main Nov 17, 2024
11 of 18 checks passed
@sc0ttkclark sc0ttkclark deleted the release/3.2.8 branch November 17, 2024 17:33
@sc0ttkclark sc0ttkclark added this to the Pods 3.2.8 milestone Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants